-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding an index for upgrade pages. #8291
Conversation
The |
Agreed. We wanted it to be more than a list, but I didn't come up with anything more substantial. Maybe, for this page, it just remains a list? @joshix |
|
||
This section contains documents specific to upgrading etcd clusters and applications. | ||
|
||
Moving from etcd API v2 to API v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be easier to read if you bolded each subheading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also agreed. We don't have any of these sorts of pages yet. Part of this exercise will be defining the format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headings suffice. Line 5 is a h2 (##
), and so on
Codecov Report
@@ Coverage Diff @@
## master #8291 +/- ##
=========================================
Coverage ? 76.33%
=========================================
Files ? 346
Lines ? 27056
Branches ? 0
=========================================
Hits ? 20652
Misses ? 4919
Partials ? 1485 Continue to review full report at Codecov.
|
This should probably be linked in |
The files linked from this page are all listed in docs.md, down at the bottom of the page under "Upgrading and compatibility". Should I add a link to this page as well? |
@zbwright probably include it as an 'Upgrading' link under 'Maintenance' so the doc isn't dangling and remove the old upgrading section so there's no duplication? |
@zbwright please squash and this should be good to merge. Thanks! |
Contributing guidelines
Please read our contribution workflow before submitting a pull request.