Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(raft/protobuf): avoid panic on unexcepted data #834

Merged
merged 1 commit into from
Jun 6, 2014
Merged

fix(raft/protobuf): avoid panic on unexcepted data #834

merged 1 commit into from
Jun 6, 2014

Conversation

yichengq
Copy link
Contributor

@yichengq yichengq commented Jun 6, 2014

@xiang90
Copy link
Contributor

xiang90 commented Jun 6, 2014

lgtm

xiang90
xiang90 reviewed Jun 6, 2014
View reviewed changes
third_party/github.com/goraft/raft/protobuf/request_vote_responses.pb.go
@@ -125,6 +125,9 @@ func (m *RequestVoteResponse) Unmarshal(data []byte) error {
if err != nil {
return err
}
if (index + skippy) > l {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philips here

@philips
Copy link
Contributor

philips commented Jun 6, 2014

lgtm

xiang90 added a commit that referenced this pull request Jun 6, 2014
@xiang90
Merge pull request #834 from unihorn/100
79c650d 
fix(raft/protobuf): avoid panic on unexcepted data
@xiang90 xiang90 merged commit 79c650d into etcd-io:master Jun 6, 2014
@xiang90 xiang90 deleted the 100 branch June 6, 2014 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yichengq @xiang90 @philips