Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] *: configure server keepalive, optimize client balancer with gray-list #8463

Closed
wants to merge 7 commits into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 29, 2017

  1. Configure server gRPC keepalive parameters
  2. Optimize client endpoint switch by gray-listing transient-failed nodes

keepalive timed-out is 'connectivity.TransientFailure'
in gRPC; it keeps retrying (calling 'Balancer.Up') until
success. This is problematic in multi-endpoint balancer
with an endpoint being blackholed. Balancer can get stuck
retrying blackholed endpoint, taking several seconds to
find healthy ones.

Select only healthy endpoints on endpoints-notify.
Gray-list unhealthy endpoints, reverting after dial timeouts.

Update: closed in favor of #8545.

@gyuho gyuho added the WIP label Aug 29, 2017
@gyuho gyuho force-pushed the keepalive branch 15 times, most recently from 67fe3fe to 1a05967 Compare August 30, 2017 21:20
@gyuho gyuho changed the title *: configure server keepalive, optimize client balancer [WIP] *: configure server keepalive, optimize client balancer Aug 31, 2017
@gyuho gyuho changed the title [WIP] *: configure server keepalive, optimize client balancer [WIP] *: configure server keepalive, optimize client balancer with gray-list Sep 1, 2017
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
keepalive timed-out is 'connectivity.TransientFailure'
in gRPC; it keeps retrying (calling 'Balancer.Up') until
success. This is problematic in multi-endpoint balancer
with an endpoint being blackholed. Balancer can get stuck
retrying blackholed endpoint, taking several seconds to
find healthy ones.

Select only healthy endpoints on endpoints-notify, if available.
Gray-list unhealthy endpoints, reverting after dial timeouts.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Sep 20, 2017

Update: closed in favor of #8545.

@gyuho gyuho deleted the keepalive branch October 5, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant