etcd-tester: add txn stresser #8510
Conversation
gyuho
force-pushed
the
txn-stresser
branch
2 times, most recently
from
00488c3
to
da510d7
Compare
|
|
||
| etcdRunnerPath: *etcdRunnerPath, | ||
| } | ||
| if scfg.keyTxnSuffixRange == 0 || scfg.keyTxnSuffixRange > 100 { |
There was a problem hiding this comment.
0 should mean don't use the txn stresser
| } | ||
| } | ||
|
|
||
| return func(ctx context.Context) (error, int64) { |
There was a problem hiding this comment.
this is too big to inline, use a separate function:
return func(ctx context.Context) { return writeTxn(ctx, kvc, keys) }| } | ||
|
|
||
| return func(ctx context.Context) (error, int64) { | ||
| n := rand.Intn(keyTxnSuffixRange) |
There was a problem hiding this comment.
The number of keys selected shouldn't be coupled to the number of keys in the working set. Half the time it'll be checking the state of half the keys or more and only one key has to be present to delete everything. Probably should set it to some small number of ops like n := rand.Intn(64) and the user can configure the conflict rate by adjusting the txn suffix range.
|
Ideally the flat txn tester would be the nested txn tester with |
gyuho
force-pushed
the
txn-stresser
branch
3 times, most recently
from
eb68578
to
3a9a734
Compare
| @@ -67,16 +69,22 @@ func (s *keyStresser) Stress() error { | |||
| kvc := pb.NewKVClient(conn) | |||
|
|
|||
| var stressEntries = []stressEntry{ | |||
| {weight: 0.7, f: newStressPut(kvc, s.keySuffixRange, s.keySize)}, | |||
| {weight: 0.24, f: newStressPut(kvc, s.keySuffixRange, s.keySize)}, | |||
| } | ||
|
|
||
| // add nested txns if any | ||
| for i := 1; i < depth; i++ { |
There was a problem hiding this comment.
I dont think i understand the depth here.
it seems to me that len(txn.Success) or len(txn.Failure) == depth. e.g
txnReq.Success[nested, nested, nested]
I thought depth means
txnReq.Success[nested[nested[nested]]]
maybe i am missing something.
| func getTxnReqs(key, val string) (com *pb.Compare, delOp *pb.RequestOp, putOp *pb.RequestOp) { | ||
| com = &pb.Compare{ | ||
| Key: []byte(key), | ||
| Target: pb.Compare_VERSION, |
There was a problem hiding this comment.
is version key version?
If version of key > 0 => key exists and then delete the key?
if version of key == 0 => no key, so put key there?
There was a problem hiding this comment.
also in what case will the version of key == 0?
from line 219 kvc.Put(context.Background(), &pb.PutRequest{, all the key are written to etcd already.
gyuho
force-pushed
the
txn-stresser
branch
2 times, most recently
from
df69011
to
81b4675
Compare
| @@ -47,6 +47,8 @@ func main() { | |||
| stressKeyLargeSize := flag.Uint("stress-key-large-size", 32*1024+1, "the size of each large key written into etcd.") | |||
| stressKeySize := flag.Uint("stress-key-size", 100, "the size of each small key written into etcd.") | |||
| stressKeySuffixRange := flag.Uint("stress-key-count", 250000, "the count of key range written into etcd.") | |||
| stressKeyTxnSuffixRange := flag.Uint("stress-key-txn-count", 100, "the count of key range written into etcd txn (max 100).") | |||
| stressKeyTxnOps := flag.Uint("stress-key-txn-ops", 1, "ops of transaction stressers (max 64).") | |||
There was a problem hiding this comment.
ops of transaction stressers (max 64) -> number of operations per transaction (max 64)?
I am unsure what does transaction stressers means.
| plog.Fatalf("stress-key-txn-count is maximum 100, got %d", scfg.keyTxnSuffixRange) | ||
| } | ||
| if scfg.keyTxnOps > 64 { | ||
| plog.Fatalf("stress-key-txn-depth is maximum 64, got %d", scfg.keyTxnOps) |
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
@fanminshi All addressed. |
|
lgtm |
functional-tester never failed for the last several months.
This adds Txn stresser.
Address #8293.