Dockerfile-test: add test image with Go 1.9 #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
docker
branch
2 times, most recently
from
e351186
to
ad93518
Compare
heyitsanthony
suggested changes
Sep 7, 2017
|
|
||
| ADD ./scripts/install-marker.sh ./scripts/install-marker.sh | ||
|
|
||
| RUN go get -v -u -tags spell github.com/chzchzchz/goword \ |
There was a problem hiding this comment.
go get github.com/wadey/gocovmerge so this container can run coverage reports?
Dockerfile-test
Outdated
| && go get -v -u honnef.co/go/tools/cmd/gosimple \ | ||
| && go get -v -u honnef.co/go/tools/cmd/unused \ | ||
| && go get -v -u honnef.co/go/tools/cmd/staticcheck \ | ||
| && ./scripts/install-marker.sh amd64 |
There was a problem hiding this comment.
comment about how to run?
Not to be blocked on Go 1.9 migration by CIs (e.g. Semaphore CI not supporting Go 1.9). Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
@heyitsanthony PTAL. Will update the semaphore commands once merged. Thanks. |
heyitsanthony
approved these changes
Sep 7, 2017
|
@heyitsanthony I will host public image on |
Codecov Report
@@ Coverage Diff @@
## master #8512 +/- ##
=========================================
Coverage ? 65.94%
=========================================
Files ? 360
Lines ? 29515
Branches ? 0
=========================================
Hits ? 19463
Misses ? 8384
Partials ? 1668
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Semaphore CI does not support Go 1.9 yet, we can do:
To test #8511.