Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/benchmark: replace 'golang.org/x/net/context' with 'context' #8528

Merged
merged 1 commit into from
Sep 8, 2017
Merged

tools/benchmark: replace 'golang.org/x/net/context' with 'context' #8528

merged 1 commit into from
Sep 8, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 8, 2017

This was missed in last PR.

@gyuho
tools/benchmark: replace 'golang.org/x/net/context' with 'context'
640c0e6 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@heyitsanthony
Copy link
Contributor

why didn't CI pick this up?

@gyuho
Copy link
Contributor Author

gyuho commented Sep 8, 2017

@heyitsanthony Think it still compiles, because golang.org/x/net/context already type-aliases context for Go 1.9.

heyitsanthony
heyitsanthony approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@gyuho gyuho merged commit ba89bbb into etcd-io:master Sep 8, 2017
@gyuho gyuho deleted the ctx branch September 8, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyitsanthony heyitsanthony heyitsanthony approved these changes

@xiang90 xiang90 Awaiting requested review from xiang90

@fanminshi fanminshi Awaiting requested review from fanminshi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gyuho @heyitsanthony