etcdserver: make dial timeout longer #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
force-pushed
the
longer_timeout
branch
from
4f3a42f
to
2303232
Compare
|
/cc @fanminshi |
fanminshi
reviewed
Sep 23, 2017
etcdserver/config.go
Outdated
| // + one RTT, which is smaller than 1/5 election timeout | ||
| return time.Second + time.Duration(c.ElectionTicks)*time.Duration(c.TickMs)*time.Millisecond/5 | ||
| // 1s for queue wait and election timeout | ||
| return time.Second + time.Duration(c.ElectionTicks)*time.Duration(c.TickMs)*time.Millisecond |
There was a problem hiding this comment.
I am curious why multiply ElectionTicks and TickMs time.Duration(c.ElectionTicks)*time.Duration(c.TickMs)?
There was a problem hiding this comment.
Generally looks good to me.
For readability, maybe go with:
time.Duration(c.ElectionTicks * c.TickMs)*time.Millisecond
This way we don't imply c.ElectionTicks is a duration (it's just count right?), until it's multiplied with the milliseconds per tick.
There was a problem hiding this comment.
I am curious why multiply ElectionTicks and TickMs
to get the duration. ticks is number of ticks. tickMS is duration per key. you can read the code around tick to understand this better.
|
lgtm |
xiang90
force-pushed
the
longer_timeout
branch
from
44f3686
to
35e2856
Compare
|
@jpbetz Thanks for the review. I am going to merge this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8532