Makefile: initial commit

[gyuho]

For #8502.

First step to make DNS/SRV tests easier to run.

[gyuho]

@xiang90 @fanminshi Please review. This is an initial step to test etcd with DNS/SRV (helpful for debugging issues like #8608).

Also Makefile is needed to make test commands more consistent between different releases.
For every minor release, we just update the GO_VERSION string while keeping the same test command make docker-test.

Currently, we hard-code Go version for all branches in CIs, so it is impossible to test with correct Go versions.

[fanminshi]

keep this # run makefile from repo root?

[fanminshi]

maybe use cd instead of pushd?

[fanminshi]

s/pushd/cd/ ?

[fanminshi]

lgtm after nits

[jpbetz]

@gyuho Having some trouble with this docker build:

$ make docker-dns-srv-test-build
docker build \
	  --tag gcr.io/etcd-development/etcd-dns-srv-test:go1.9.1 \
	  --file ./e2e/docker-dns-srv/Dockerfile \
	  ./e2e/docker-dns-srv
...
Successfully built 46d8c5294e3f
docker run \
	  --rm \
	  --dns 127.0.0.1 \
	  gcr.io/etcd-development/etcd-dns-srv-test:go1.9.1 \
	  /bin/bash -c "/etc/init.d/bind9 start && cat /dev/null >/etc/hosts && dig +noall +answer SRV _etcd-client-ssl._tcp.etcd.local && dig +noall +answer SRV _etcd-server-ssl._tcp.etcd.local && dig +noall +answer m1.etcd.local m2.etcd.local m3.etcd.local"
WARNING: Localhost DNS setting (--dns=127.0.0.1) may fail in containers.
Starting domain name service...: bind9 failed!
make: *** [docker-dns-srv-test-build] Error 1

$ docker --version
Docker version 1.12.6, build 78d1802

Still working on getting more detailed logging from a bind9 init.d start failure.

Any idea what might be wrong?
What version of docker where you running this with?

[gyuho]

@jpbetz Hmm works for me?

Docker version 17.09.0-ce, build afdb6d4

go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/gyuho/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/1x/0sf85stn6sb01sx6ncs7x_ph0000gn/T/go-build867045777=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

[jpbetz]

@gyuho What version of bind9 did apt install for you?

$ docker run gcr.io/etcd-development/etcd-dns-srv-test:go1.9.1 apt show bind9 2>/dev/null
Package: bind9
Version: 1:9.10.3.dfsg.P4-12.3+deb9u3
...

[gyuho]

Looks same

docker run gcr.io/etcd-development/etcd-dns-srv-test:go1.9.1 apt show bind9 2>/dev/null
Package: bind9
Version: 1:9.10.3.dfsg.P4-12.3+deb9u3
...

?

Maybe docker issue...? Have you tried running with sudo if you run on Linux?

[gyuho]

Works in my GCP VM too.

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.3 LTS
Release:	16.04
Codename:	xenial

$ docker --version
Docker version 17.09.0-ce, build afdb6d4

$ uname -a
Linux gyuho-fast 4.10.0-35-generic #39~16.04.1-Ubuntu SMP Wed Sep 13 09:02:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

[jpbetz]

@gyuho It's something with that older docker version. Networking maybe? Everything works with a more recent one. I'm all set now. Thanks!

[xiang90]

@gyuho @jpbetz

probably the build script should check docker version then? or it would confuse other people too :P.

[jpbetz]

@xiang90 Absolutely. I've figured out the incompatibility and submitted a fix (#8661) for the docker files.

[glevand]

You'll need to have some way to distinguish the docker image architecture. Maybe something like gcr.io/etcd-development/etcd-test:$(_GO_VERSION)-$(ARCH)., and also have arch specific docker files.