clientv3: fix health balancer, retry #8688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why this is still wip? |
gyuho
commented
Oct 12, 2017
| @@ -473,8 +473,8 @@ func TestKVNewAfterClose(t *testing.T) { | |||
|
|
|||
| donec := make(chan struct{}) | |||
| go func() { | |||
| if _, err := cli.Get(context.TODO(), "foo"); err != context.Canceled { | |||
| t.Fatalf("expected %v, got %v", context.Canceled, err) | |||
There was a problem hiding this comment.
This is added because previously, no matter what, retry.go switches endpoint (resets connection) so didn't hit grpc.ErrClientConnClosing path. Now, only does switch when it's transient error, so grpc.ErrClientConnClosing is expected when concurrent goroutine closes client.
gyuho
force-pushed
the
transient
branch
2 times, most recently
from
68be468
to
a56d5f4
Compare
gyuho
changed the title
gyuho
changed the title
gyuho
changed the title
xiang90
reviewed
Oct 14, 2017
clientv3/retry.go
Outdated
| @@ -181,7 +190,7 @@ type retryLeaseClient struct { | |||
| func RetryLeaseClient(c *Client) pb.LeaseClient { | |||
There was a problem hiding this comment.
comment needs to be fixed.
xiang90
reviewed
Oct 14, 2017
clientv3/retry.go
Outdated
| @@ -181,7 +190,7 @@ type retryLeaseClient struct { | |||
| func RetryLeaseClient(c *Client) pb.LeaseClient { | |||
| retry := &retryLeaseClient{ | |||
| pb.NewLeaseClient(c.conn), | |||
| c.newRetryWrapper(isReadStopError), | |||
| c.newRetryWrapper(false), | |||
There was a problem hiding this comment.
this is incorrect. leaseGrant is write, but list leases is read.
xiang90
reviewed
Oct 14, 2017
clientv3/retry.go
Outdated
| type retryClusterClient struct { | ||
| pb.ClusterClient | ||
| retryf retryRpcFunc | ||
| } | ||
|
|
||
| // RetryClusterClient implements a ClusterClient that uses the client's FailFast retry policy. | ||
| func RetryClusterClient(c *Client) pb.ClusterClient { | ||
| return &retryClusterClient{pb.NewClusterClient(c.conn), c.newRetryWrapper(isWriteStopError)} | ||
| return &retryClusterClient{pb.NewClusterClient(c.conn), c.newRetryWrapper(true)} |
There was a problem hiding this comment.
not correct. memerlist is read.
|
we need to make the wrapper to understand read/write type per RPC, not per Service. A service might have both read/write type RPCs. |
gyuho
force-pushed
the
transient
branch
4 times, most recently
from
d915681
to
b0dee09
Compare
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Set grpc.FailFast==true, so that RPCs fail immediately on broken connections or unreachable servers. And let client balancer handle the retries. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
…erClose Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
transient
branch
4 times, most recently
from
9396c35
to
db175aa
Compare
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. efd7800