Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/v2: regenerate with latest ugorji/go/codec #8721

Merged
merged 5 commits into from
Oct 20, 2017
Merged

client/v2: regenerate with latest ugorji/go/codec #8721

merged 5 commits into from
Oct 20, 2017

Conversation

andrewmeissner
Copy link

@andrewmeissner andrewmeissner commented Oct 20, 2017

Updating the github.com/ugorji/go/codec dependency to the latest and regenerates the keys.[generated].go file with the updated codecgen executable.

@gyuho
Copy link
Contributor

gyuho commented Oct 20, 2017

@andrewmeissner Could you format your commit titles to something like

glide: update github.com/ugorji/go/codec
client: regenerate

And does client build after your patch?

Updating github.com/ugorji/go/codec to the latest commit/version
Updating the codec required codecgen to be reran on the client/keys.go file.  This is the result of that run.
@andrewmeissner
Copy link
Author

@gyuho I updated the commit messages. I ran a go build -o client *.go inside the client dir and it seemed to build just fine. If I need to build it another way let me know and I'll do that as well.

@gyuho
Copy link
Contributor

gyuho commented Oct 20, 2017

@andrewmeissner It doesn't build in our CIs. Did you run ./scripts/updatedep.sh in your first commit?

ran the updatedep.sh
@andrewmeissner
Copy link
Author

@gyuho I was not aware (hahaha). Just ran it and committed the files it modified. :)

@gyuho
Copy link
Contributor

gyuho commented Oct 20, 2017

Thanks! We will merge this when CI passes.

@gyuho gyuho changed the title Feature/update codecgen client/v2: regenerate with latest ugorji/go/codec Oct 20, 2017
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor

gyuho commented Oct 20, 2017

@ugorji We had to manually patch the generated code to pass our linting tests.
Please see the last two commits if interested. Thanks!

@ugorji
Copy link

ugorji commented Oct 20, 2017

@gyuho thanks much for the heads up. I will look into why the redundant stuff was there, and the yhnn2=0 one also.

@gyuho gyuho merged commit f83ac25 into etcd-io:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants