clientv3/retry: clean up retryRPCFunc #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
commented
Oct 20, 2017
clientv3/retry.go
Outdated
| return &retryClusterClient{&nonRepeatableClusterClient{cc, nonRepeatableRetry}, repeatableRetry} | ||
| return &retryClusterClient{ | ||
| cc: pb.NewClusterClient(c.conn), | ||
| retryf: c.newAuthRetryWrapper(c.newRetryWrapper()), |
There was a problem hiding this comment.
I am not sure why we had newAuthRetryWrapper only for KV and Lease API. This adds newAuthRetryWrapper to all APIs.
gyuho
force-pushed
the
cleanup-retry
branch
2 times, most recently
from
be4484e
to
a76623c
Compare
gyuho
force-pushed
the
cleanup-retry
branch
2 times, most recently
from
486509e
to
60d3136
Compare
Codecov Report
@@ Coverage Diff @@
## master #8724 +/- ##
=========================================
Coverage ? 75.89%
=========================================
Files ? 359
Lines ? 29807
Branches ? 0
=========================================
Hits ? 22623
Misses ? 5598
Partials ? 1586
Continue to review full report at Codecov.
|
gyuho
force-pushed
the
cleanup-retry
branch
2 times, most recently
from
d34cfae
to
13720a2
Compare
gyuho
changed the title
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #8691.