clientv3/integration: add blackhole tests for range RPCs #8790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
gyuho
force-pushed
the
blackhole-immutable
branch
from
02ee4b4
to
bac6a43
Compare
gyuho
changed the title
gyuho
force-pushed
the
blackhole-immutable
branch
from
bac6a43
to
86e72a7
Compare
|
newly added tests are failing. |
gyuho
force-pushed
the
blackhole-immutable
branch
2 times, most recently
from
8cfee6e
to
ea73348
Compare
xiang90
reviewed
Oct 31, 2017
| func TestBalancerUnderBlackholeNoKeepAliveLinearizableGetShortTimeout(t *testing.T) { | ||
| testBalancerUnderBlackholeNoKeepAlive(t, func(cli *clientv3.Client, ctx context.Context) error { | ||
| _, err := cli.Get(ctx, "a") | ||
| if err == context.DeadlineExceeded { |
There was a problem hiding this comment.
is this correct? l-get needs to go through raft, wont etcd return errtimeout when the leader is changing?
xiang90
reviewed
Oct 31, 2017
| func TestBalancerUnderBlackholeNoKeepAliveLinearizableGetLongTimeout(t *testing.T) { | ||
| testBalancerUnderBlackholeNoKeepAlive(t, func(cli *clientv3.Client, ctx context.Context) error { | ||
| _, err := cli.Get(ctx, "a") | ||
| if err == context.DeadlineExceeded { |
There was a problem hiding this comment.
and what is the difference between the longtimeout and shorttimeout one for l-get?
There was a problem hiding this comment.
Yeah, old one was wrong. We expect time-out errors on blackholed node, regardless of context timeout duration. Just removed it. Now only tests if it can switch out of blackholed endpoint after context timeout errors.
gyuho
force-pushed
the
blackhole-immutable
branch
from
ea73348
to
a63307e
Compare
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
blackhole-immutable
branch
from
a63307e
to
8d23e1c
Compare
|
lgtm if test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8711