standby server: save Running info correctly #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running should be true when Start, and set to false when switching to the other mode.
|
@unihorn Can there be a test that covers this? |
|
lgtm |
|
Looking forward for this PR as we encounter this in prod from time to time :-) |
yichengq
added a commit
that referenced
this pull request
Jul 25, 2014
standby server: save Running info correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running should be true when Start, and set to false when switching to
the other mode.
The original code keeps Running as true if server was standby mode before.
The bug causes the following problem:
If a node switched to peer mode from standby mode, it will goes into standby mode when restart. If all nodes have the same case, full down/up will fail.