-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "embed: fix HTTPs + DNS SRV discovery" #8884
Conversation
we need to update the documentation to make it clear that the TLS certs for DNS discovery must include the root domain in SAN to prevent mitm attack. |
This reverts commit f79d5aa.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
eaf3388
to
37b3108
Compare
@xiang90 I've highlighted this change in PTAL. |
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #8884 +/- ##
=========================================
Coverage ? 76.19%
=========================================
Files ? 359
Lines ? 29721
Branches ? 0
=========================================
Hits ? 22646
Misses ? 5504
Partials ? 1571
Continue to review full report at Codecov.
|
In 3.2.8, both configurations work with TLS/SRV
In 3.2.9, we added wildcard to peer server name (e.g.
*.etcd.local
when DNS cluster isetcd.local
).Now the first configuration doesn't work
Second configuration still works
But, not every tool supports wildcard certs.
We are reverting this change, also in upcoming patch release 3.2.10.
Address #8445 and #8798.
Reverts #8651.