Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/patch: fix some typos in README, make cherrypick.sh executable #8946

Merged
merged 1 commit into from
Nov 30, 2017
Merged

hack/patch: fix some typos in README, make cherrypick.sh executable #8946

merged 1 commit into from
Nov 30, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 30, 2017

No description provided.

@gyuho gyuho requested a review from jpbetz November 30, 2017 19:12
@gyuho
hack/patch: fix some typos in README, make cherrypick.sh executable
3167780 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Nov 30, 2017

@jpbetz This is successfully run to create #8947.

My git remote -v looks like this:

$ git remote -v

gyuho	git@github.com:gyuho/etcd.git (fetch)
gyuho	git@github.com:gyuho/etcd.git (push)
origin	git@github.com:coreos/etcd.git (fetch)
origin	git@github.com:coreos/etcd.git (push)

jpbetz
jpbetz approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for fixing!

@jpbetz
Copy link
Contributor

jpbetz commented Nov 30, 2017

lgtm

@gyuho gyuho merged commit b041ce5 into etcd-io:master Nov 30, 2017
@gyuho gyuho deleted the cherry-pick branch November 30, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gyuho @jpbetz