Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic on shut down when TLS configuration is present #8986

Closed
wants to merge 3 commits into from
Closed

Avoid panic on shut down when TLS configuration is present #8986

wants to merge 3 commits into from

Commits on Dec 7, 2017

  1. embed: Avoid panic when shutting down gRPC Server 

    Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
    @jamesdphillips
    jamesdphillips committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    aae48b6 View commit details
    Browse the repository at this point in the history

  2. embed: only gracefully shutdown insecure grpc.Server 

    Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
    @gyuho
    gyuho committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    f9c1b6f View commit details
    Browse the repository at this point in the history

  3. integration: test GracefulShutdown on secure embedded server 

    Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
    @gyuho
    gyuho committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    c59691b View commit details
    Browse the repository at this point in the history