embed: stop *grpc.Server on *serveCtx serve error #8992
Conversation
|
can we add a test case to cover this? |
|
@xiang90 It's hard unless we refactor embed package to break it down to smaller pieces. In integration tests, I tried triggering failure to this path by passing nil https://github.com/coreos/etcd/blob/e3da56a8dfb88c7ee8f6c282c986fb5154700910/embed/etcd.go#L518 Another way that |
Codecov Report
@@ Coverage Diff @@
## master #8992 +/- ##
==========================================
- Coverage 76.03% 75.96% -0.07%
==========================================
Files 359 359
Lines 29819 29825 +6
==========================================
- Hits 22672 22656 -16
- Misses 5563 5585 +22
Partials 1584 1584
Continue to review full report at Codecov.
|
embed/serve.go
Outdated
| @@ -101,6 +101,7 @@ func (sctx *serveCtx) serve( | |||
| opts := []grpc.DialOption{grpc.WithInsecure()} | |||
| gwmux, err := sctx.registerGateway(opts) | |||
| if err != nil { | |||
| gs.Stop() | |||
There was a problem hiding this comment.
probably make error as named return. and we always try to stop gs if it is not nil
If serve errors before *grpc.Server is sent to serversC, it should be closed manually. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
|
lgtm |
I forgot to handle this in #8987.
If serve errors before *grpc.Server is sent to serversC,
it should be closed manually.
@xiang90