Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: test large request response back from server #9046

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Dec 19, 2017

Address #9043.
Won't fix it, but we need test coverage on response back
from server as well.

Will fix the issue in the following PR.

/cc @jpbetz @xiang90

Address etcd-io#9043.
Won't fix it, but we need test coverage on response back
from server as well.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #9046 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9046      +/-   ##
==========================================
+ Coverage   76.08%   76.09%   +0.01%     
==========================================
  Files         359      359              
  Lines       29841    29841              
==========================================
+ Hits        22704    22707       +3     
+ Misses       5559     5556       -3     
  Partials     1578     1578
Impacted Files Coverage Δ
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
pkg/adt/interval_tree.go 82.88% <0%> (-3.61%) ⬇️
proxy/grpcproxy/watch.go 91.92% <0%> (-3.11%) ⬇️
clientv3/health_balancer.go 85.97% <0%> (-1.53%) ⬇️
mvcc/watchable_store.go 90.03% <0%> (ø) ⬆️
lease/leasehttp/http.go 63.97% <0%> (ø) ⬆️
etcdserver/api/v3rpc/lease.go 83.82% <0%> (ø) ⬆️
clientv3/namespace/watch.go 93.93% <0%> (ø) ⬆️
clientv3/watch.go 95.04% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a600a...abfc09b. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Dec 20, 2017

lgtm

@jpbetz
Copy link
Contributor

jpbetz commented Dec 20, 2017

lgtm as well

@gyuho gyuho merged commit 828289d into etcd-io:master Dec 20, 2017
@gyuho gyuho deleted the request-limit branch December 20, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants