Log: add information statement #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding information that when config file is used other command line flags and env variables will be ignored. This changes are a follow up of a disucssion under PR, etcd-io#9066
|
lgtm. Merging when CI turns green.
…On Wed, Dec 27, 2017 at 5:17 PM Sahdev Zala ***@***.***> wrote:
Adding information that when config file is used other command line flags
and env variables will be ignored. This changes are a follow up of a
disucssion under PR #9066 <#9066>
Contributing guidelines
Please read our contribution workflow
<https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md#contribution-flow>
before submitting a pull request.
------------------------------
You can view, comment on, or merge this pull request online at:
#9069
Commit Summary
- Log: add information statement
File Changes
- *M* etcdmain/config.go
<https://github.com/coreos/etcd/pull/9069/files#diff-0> (2)
Patch Links:
- https://github.com/coreos/etcd/pull/9069.patch
- https://github.com/coreos/etcd/pull/9069.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9069>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AERbyzMdKp03VKew_JBr1mNsvNlFQjZuks5tEsIPgaJpZM4RN2fP>
.
|
|
Thanks @xiang90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding information that when config file is used other command line flags
and env variables will be ignored. This changes are a follow up of a
disucssion under PR #9066
Contributing guidelines
Please read our contribution workflow before submitting a pull request.