Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: range-end is not a flag and should not be used #9076

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

spzala
Copy link
Member

@spzala spzala commented Jan 2, 2018

As README declares in the beginning, flags can have dash and it should be
replaced with underscore while using. Also flags or commands are emphasized
in general. The range-end is not a flag or valid doc word and should not be
used as such.

Fixes #9075

Contributing guidelines

Please read our contribution workflow before submitting a pull request.

As README declares in the beginning, flags can have dash and it should be
replaced with underscore while using. Also flags or commands are emphasized
in general. The range-end is not a flag or valid doc word and should not be
used as such.
@xiang90
Copy link
Contributor

xiang90 commented Jan 2, 2018

lgtm.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fdec12c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9076   +/-   ##
=========================================
  Coverage          ?   76.05%           
=========================================
  Files             ?      359           
  Lines             ?    29952           
  Branches          ?        0           
=========================================
  Hits              ?    22781           
  Misses            ?     5590           
  Partials          ?     1581

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdec12c...f6f4589. Read the comment docs.

@xiang90 xiang90 merged commit e6a46a0 into etcd-io:master Jan 2, 2018
@spzala spzala deleted the rangeend branch September 13, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants