Doc: Create doc for etcdctl check perf command #9082
Conversation
| # FAIL: Throughput too low: 6808 writes/s | ||
| # PASS: Slowest request took 0.228191s | ||
| # PASS: Stddev is 0.033547s | ||
| # FAIL |
There was a problem hiding this comment.
probably explain a little bit why this example fails? this is testing a large load on a laptop?
There was a problem hiding this comment.
Sure, that's a good idea. Yes, I guess the failure is due to what you mentioned - large workload on a single node cluster on laptop. Thanks!
There was a problem hiding this comment.
Great! Let us document the reason of the failure, and get this PR merged :)
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #9082 +/- ##
=========================================
Coverage ? 75.91%
=========================================
Files ? 359
Lines ? 29957
Branches ? 0
=========================================
Hits ? 22743
Misses ? 5626
Partials ? 1588Continue to review full report at Codecov.
|
Create a doc for check commands with perf subcommand. Fixes etcd-io#9072
|
retest |
|
@xiang90 thanks but I still don't understand why this PR changes making semaphore fail. First time I noticed the TestWatchRestore related failure and thought it could be something just a one time failure for some reason and I guess it does look that way because this time it's a different error than TestWatchRestore. I also run .semaphore.sh on my local VM and that went fine. |
|
Last time, 386-integration and amd64-integration both failed but this time it appears that it's only amd64- failing with different error as I mentioned. |
|
@spzala it is not because of this PR i believe. probably a test flakes. |
|
@xiang90 thanks!! |
Create a doc for etcdctl check commands with perf subcommand.
Fixes #9072
Contributing guidelines
Please read our contribution workflow before submitting a pull request.