*: add "--unsupported-arch" flag to remove confusing error message #9089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
flag-error
branch
3 times, most recently
from
a237048
to
814da31
Compare
gyuho
force-pushed
the
flag-error
branch
2 times, most recently
from
321dc7c
to
2a1fb13
Compare
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho
changed the title
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
flag-error
branch
2 times, most recently
from
419a9d4
to
e8aa9a8
Compare
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9089 +/- ##
=========================================
Coverage ? 75.96%
=========================================
Files ? 359
Lines ? 29953
Branches ? 0
=========================================
Hits ? 22754
Misses ? 5608
Partials ? 1591
Continue to review full report at Codecov.
|
xiang90
reviewed
Jan 4, 2018
| return cfg.Validate() | ||
| } | ||
|
|
||
| func (cfg *Config) Validate() error { | ||
| // TODO qualify arm64 | ||
| goArch := runtime.GOARCH |
xiang90
reviewed
Jan 4, 2018
| @@ -32,7 +32,7 @@ For etcd to officially support a new platform as stable, a few requirements are | |||
|
|
|||
| etcd has known issues on 32-bit systems due to a bug in the Go runtime. See the [Go issue][go-issue] and [atomic package][go-atomic] for more information. | |||
|
|
|||
| To avoid inadvertently running a possibly unstable etcd server, `etcd` on unstable or unsupported architectures will print a warning message and immediately exit if the environment variable `ETCD_UNSUPPORTED_ARCH` is not set to the target architecture. | |||
| To avoid inadvertently running a possibly unstable etcd server, `etcd` on unstable or unsupported architectures will print a warning message and immediately exit if flag `--unsupported-arch` or environment variable `ETCD_UNSUPPORTED_ARCH` is not set to the target architecture. | |||
There was a problem hiding this comment.
there is no flag for this feature since we do not really want to promote the usage of running etcd on unsupported platform, and do not want to make it a feature flag. env is much more easier to deprecated for example.
There was a problem hiding this comment.
Then should we just have special handling for ETCD_UNSUPPORTED_ARCH? Otherwise, we will keep warning
pkg/flags: unrecognized environment variable ETCD_UNSUPPORTED_ARCH=arm64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9077.
The confusing warning disappears with this.