Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #9415 #9502

Merged

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Mar 28, 2018

Cherry pick of #9415 on release-3.2.

#9415: rafthttp: add "ActivePeers" to "Transport"

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@jpbetz jpbetz mentioned this pull request Mar 28, 2018
25 tasks
@gyuho
Copy link
Contributor

gyuho commented Mar 28, 2018

Oh, didn't notice compile error https://travis-ci.org/coreos/etcd/jobs/359466877#L610

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@jpbetz jpbetz force-pushed the automated-cherry-pick-of-#9415-release-3.2 branch from 633e1c8 to e6c5cdf Compare March 28, 2018 17:58
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 28, 2018

@gyuho Fixed. It builds locally now. I've also manually reviewed the changes and they look correct now.

@gyuho
Copy link
Contributor

gyuho commented Mar 28, 2018

Yeah, somehow semaphore didn't get triggered. Let me run test suites locally.

@jpbetz jpbetz merged commit 29185da into etcd-io:release-3.2 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants