Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] scripts: Add script that performs entire release workflow #9582

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Apr 18, 2018

We should test out this script very carefully for a couple actual releases before giving it the stamp of approval, but I wanted to post it up in a PR so it's available.

The steps it takes are almost identical to those taken by the 'etcd-release-runbook' (https://goo.gl/Gxwysq) workflow, with the following differences:

  • Not all steps have been implemented yet. In particularly the signing step is not yet implemented.
  • The script performs a variety of additional checks in an attempt to avoid mistakes, e.g.: "does the current go version match the one in .travis.yml? Are gpg keys set up properly? Do the version/version.go, git tag version and desired go release version all match? ..."

Please try it out and send me feedback.

@jpbetz jpbetz self-assigned this Apr 18, 2018
@jpbetz jpbetz requested a review from gyuho April 18, 2018 20:42
@gyuho
Copy link
Contributor

gyuho commented Apr 18, 2018

@jpbetz Let's try this script in our next April patch release, before merge and backport. Thanks.

@jpbetz jpbetz changed the title [WIP] scripts: Add scripts/release that performs entire release workflow [WIP] scripts: Add script that performs entire release workflow Apr 18, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d0847f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9582   +/-   ##
=========================================
  Coverage          ?   69.27%           
=========================================
  Files             ?      369           
  Lines             ?    33660           
  Branches          ?        0           
=========================================
  Hits              ?    23318           
  Misses            ?     8640           
  Partials          ?     1702

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0847f4...7750974. Read the comment docs.

@gyuho gyuho mentioned this pull request Apr 19, 2018
18 tasks
@gyuho
Copy link
Contributor

gyuho commented Apr 24, 2018

Merging to try this today. Thanks!

@gyuho gyuho merged commit 6140413 into etcd-io:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants