-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: binding listeners must be IP. #9638
Conversation
@@ -391,7 +391,7 @@ infra2.example.com. 300 IN A 10.0.1.12 | |||
|
|||
#### Bootstrap the etcd cluster using DNS | |||
|
|||
etcd cluster members can listen on domain names or IP address, the bootstrap process will resolve DNS A records. | |||
etcd cluster members can advertise domain names or IP address, the bootstrap process will resolve DNS A records. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more details? We can just say something like https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md#change-in---listen-peer-urls-and---listen-client-urls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense I found that after the fact. Will update to reflect versions.
lgtm in general. |
@gyuho updated, thanks. |
Codecov Report
@@ Coverage Diff @@
## master #9638 +/- ##
=========================================
- Coverage 69.33% 69.2% -0.14%
=========================================
Files 373 373
Lines 34427 34427
=========================================
- Hits 23870 23824 -46
- Misses 8867 8904 +37
- Partials 1690 1699 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @hexfusion
ref: #6336, #9575