Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: test with "unparam", fix "v2v3" store stored get #9712

Merged
merged 15 commits into from
May 10, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 9, 2018

Fix #8068.
ref. #9064.

gyuho added 15 commits May 9, 2018 15:39
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e0b74d4). Click here to learn what that means.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9712   +/-   ##
=========================================
  Coverage          ?   69.35%           
=========================================
  Files             ?      373           
  Lines             ?    35039           
  Branches          ?        0           
=========================================
  Hits              ?    24301           
  Misses            ?     8975           
  Partials          ?     1763
Impacted Files Coverage Δ
pkg/transport/timeout_listener.go 80% <0%> (ø)
etcdmain/gateway.go 32.78% <0%> (ø)
etcdctl/ctlv3/command/watch_command.go 47.09% <0%> (ø)
etcdserver/api/v2v3/store.go 0% <0%> (ø)
etcdctl/ctlv3/command/del_command.go 70.73% <100%> (ø)
integration/bridge.go 71.75% <100%> (ø)
pkg/transport/listener.go 58.24% <100%> (ø)
etcdserver/v2auth/auth.go 72.33% <100%> (ø)
etcdctl/ctlv3/command/put_command.go 78.94% <100%> (ø)
etcdctl/ctlv3/command/get_command.go 77.27% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b74d4...e7adfb0. Read the comment docs.

@gyuho gyuho merged commit 67b1ff6 into etcd-io:master May 10, 2018
@gyuho gyuho deleted the unparam branch May 10, 2018 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants