Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: promote debugging metrics #9764

Closed
wants to merge 10 commits into from
Closed

*: promote debugging metrics #9764

wants to merge 10 commits into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 23, 2018

gyuho added 8 commits May 23, 2018 14:46
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@xiang90
Copy link
Contributor

xiang90 commented May 23, 2018

can you explain why do we want to promote these metrics?

gyuho added 2 commits May 23, 2018 15:10
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho added the WIP label May 23, 2018
@gyuho
Copy link
Contributor Author

gyuho commented May 23, 2018

@xiang90 Thought etcd_debugging_* has always been experimental? Mainly to make names consistent before improving our monitoring and alert guides.

Or should we make other metrics be consistent with etcd_debugging_*? Since we have etcd_server_version, defined right below etcd_debugging_server_lease_expired_total? We also have etcd_mvcc_hash_duration_seconds, which should be renamed to etcd_debugging_mvcc_hash_duration_seconds?

@gyuho
Copy link
Contributor Author

gyuho commented May 23, 2018

ref. https://github.com/coreos/etcd/blob/master/Documentation/metrics.md#etcd_debugging-namespace-metrics

The metrics under the etcd_debugging prefix are for debugging. They are very implementation dependent and volatile. They might be changed or removed without any warning in new etcd releases. Some of the metrics might be moved to the etcd prefix when they become more stable.

We could serve etcd_debugging_* in parallel with etcd_* for smooth migration in v3.4, and deprecate debugging namespace in v3.5 (we do this for etcd --log-output flag).

@gyuho
Copy link
Contributor Author

gyuho commented Jun 5, 2018

Will only promote etcd_debugging_mvcc_db_total_size_in_bytes in a backward compatible way (since it's used in https://github.com/coreos/etcd/blob/master/Documentation/op-guide/grafana.json#L344). I asked other production users, and found out quite a few are already using etcd_debugging_* metrics in production.

@gyuho gyuho closed this Jun 5, 2018
@gyuho gyuho deleted the debug branch June 5, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants