Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl/ctlv3: etcd v3.4 makes ETCDCTL_API=3 by default #9784

Merged
merged 1 commit into from
May 29, 2018

Conversation

vimalk78
Copy link
Contributor

fixes #9600

@vimalk78
Copy link
Contributor Author

some test cases set ETCDCTL_API by calling os.Setenv("ETCDCTL_API", "3")
i didnt remove these invocations.

i am not sure in which test cases ETCDCTL_API=2 is used , if any.

@gyuho if you can point out any such case, i will change that too.

@vimalk78 vimalk78 force-pushed the 9600_ETCDCTL_API_3_default branch from e019910 to 25bc657 Compare May 29, 2018 00:58
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ce918ce). Click here to learn what that means.
The diff coverage is 17.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9784   +/-   ##
=========================================
  Coverage          ?   63.87%           
=========================================
  Files             ?      376           
  Lines             ?    35223           
  Branches          ?        0           
=========================================
  Hits              ?    22500           
  Misses            ?    11120           
  Partials          ?     1603
Impacted Files Coverage Δ
etcdctl/ctlv3/ctl_cov.go 0% <0%> (ø)
etcdctl/ctlv3/ctl_nocov.go 0% <0%> (ø)
etcdctl/ctlv2/ctl.go 86.95% <100%> (ø)
etcdctl/main.go 54.54% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce918ce...25bc657. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented May 29, 2018

lgtm

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

etcd v3.4 makes ETCDCTL_API=3 by default
4 participants