etcdmain: backport support for different certs for etcd-gRPC proxy #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables TLS termination in grpcproxy.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
👍 |
|
@xmudrii Could you also add this change to https://github.com/coreos/etcd/blob/master/CHANGELOG-3.2.md? |
|
@gyuho No problem but not sure at all how to do it. I have created this PR against Should I create a new PR? Is there some guidelines for backporting to older versions? |
|
@xmudrii Yes. Separate PR should work. Thanks! |
gyuho
added a commit
that referenced
this pull request
Jul 2, 2018
Update CHANGELOG-3.2 to include changes from #9894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes backporting support for different certs for the etcd-gRPC proxy. The feature has been already introduced in #8277, but not backported to v3.2.
This PR cherry-picks
1365f87d4046469bcc94ad03048a52b8b4367bb0, as well ase5531a4d54e89338e35994ee1c7e69c87c18d0e8, as it introduced some changes in the gRPC-proxy code.The
efbee9d8c788e434cae8da03b03ad55f5a6f67c5andc5447c2ec91bc349117327de9f7f019cf6cdf1b5commits have not been cherry-picked, as they require changes to the TLS part of the code. I wanted to keep this PR minimal, with changes only made to the gRPC-Proxy feature, in order to prevent the backwards-compatibility issues.This PR adds the most important features to enable securing the etcd-gRPC proxy. If you'd like, I can add those two commits as well.
Without flags introduced in this PR, it's not possible (or not that easy) to secure the etcd exposed by etcd-gRPC proxy v3.2.
For example, my GSoC project–
etcdproxy-controllerexposes etcd for Kubernetes API servers using the etcd-gRPC proxy. When working in production environments, it's very important to have etcd secured, but to keep it fully-compatible with Kubernetes, which is still on v3.2, we should use v3.2 images, that doesn't support TLS in the etcd-gRPC proxy.I would like to know what do you think about this proposal and is it possible to backport the feature to v3.2.