clientv3: fix keepalive send interval when response queue is full #9952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
fix-keepalive
branch
2 times, most recently
from
15fdb5b to
a876165
Compare
Codecov Report
@@ Coverage Diff @@
## master #9952 +/- ##
=========================================
+ Coverage 69.12% 69.23% +0.1%
=========================================
Files 386 386
Lines 35784 35789 +5
=========================================
+ Hits 24735 24777 +42
+ Misses 9232 9213 -19
+ Partials 1817 1799 -18
Continue to review full report at Codecov.
|
xiang90
reviewed
Jul 22, 2018
clientv3/integration/lease_test.go
Outdated
| // expect lease keepalive every 10-second | ||
| lresp, err := lapi.Grant(context.Background(), 30) | ||
| if err != nil { | ||
| t.Errorf("failed to create lease %v", err) |
There was a problem hiding this comment.
you should switch t.errorf and t.fatelf
errorf is to report errors in test, which does not match the test case expectation.
fatalf is to report errors that are not tested in the case, but are failing.
|
lgtm |
client should update next keepalive send time even when lease keepalive response queue becomes full. Otherwise, client sends keepalive request every 500ms regardless of TTL when the send is only expected to happen with the interval of TTL / 3 at minimum. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
|
Sorry, I'm late.thanks for fix. @gyuho |
|
@cfc4n Thanks for report. This will be backported and released with patch release. |
luoyancn
added a commit
to luoyancn/dubhe
that referenced
this pull request
Aug 11, 2018
When use etcd keepalive method, we must consume all messages from the queen it retured.Otherwise, the queen would be full. See more detail, visit the follow links: etcd-io/etcd#9952 etcd-io/etcd#8168 https://github.com/coreos/etcd/blob/master/clientv3/concurrency/session.go#L63 https://www.cnxct.com/etcd-lease-keepalive-debug-note/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client should update next keepalive send time
even when lease keepalive response queue becomes full.
Otherwise, client sends keepalive request every 500ms
regardless of TTL when the send is only expected to happen
with the interval of TTL / 3 at minimum.
Fix #9911.
/cc @cfc4n