Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GitHub action dependency versions #74

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Aug 4, 2024

GitHub action dependencies weren't pointing to commit hashes. Pin them to improve the OpenSSF Scorecard Report score.

Related to etcd-io/etcd#18362

GitHub action dependencies weren't pointing to commit hashes. Pin them
to improve the OpenSSF Scorecard Report score.

Signed-off-by: Ivan Valdes <iv@a.ki>
@@ -23,9 +23,8 @@ jobs:
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: ${{ steps.goversion.outputs.goversion }}
- uses: actions/checkout@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this step is duplicated, as it is already defined on line 20.

- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
- id: goversion
run: echo "goversion=$(cat .go-version)" >> "$GITHUB_OUTPUT"
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: ${{ steps.goversion.outputs.goversion }}
- uses: actions/checkout@v4

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e40a248 into etcd-io:master Aug 4, 2024
5 checks passed
@ivanvc ivanvc deleted the pin-github-action-dependency-versions branch August 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants