Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 0.7.6 version does not throw an exception when keepAliveOnce failed #1254

Closed
sukidesuka opened this issue Oct 18, 2023 · 3 comments · Fixed by #1256
Closed

The 0.7.6 version does not throw an exception when keepAliveOnce failed #1254

sukidesuka opened this issue Oct 18, 2023 · 3 comments · Fixed by #1256

Comments

@sukidesuka
Copy link

sukidesuka commented Oct 18, 2023

Versions

  • etcd: 3.5.9
  • jetcd: 0.7.6
  • java: 11

Describe the bug

If you use keepAliveOnce on an expired lease, it should throw an
io.etcd.jetcd.common.exception.EtcdException: etcdserver: requested lease not found exception.
However, in version 0.7.6, nothing happens and it behaves as if the lease is successfully renewed.

When I used jetcd 0.7.5, it immediately worked fine.

To Reproduce

  1. Use grant to create a lease.
  2. Wait for the lease to expire.
  3. Use keepAliveOnce to renew the lease.

Expected behavior
throw an io.etcd.jetcd.common.exception.EtcdException: etcdserver: requested lease not found exception.

Additional context

Normally, I would start by creating a lease and then binding it to a key. So if the reproduction fails, you can try binding the lease to a key.

My ETCD is running in a Kubernetes cluster and using 3 replicas.

@sukidesuka
Copy link
Author

@lburgazzoli

@lburgazzoli
Copy link
Collaborator

@sukidesuka do you have any time to provide a reproduce in a form of an integration test ?

lburgazzoli added a commit to lburgazzoli/etcd-io-jetcd that referenced this issue Oct 18, 2023
@lburgazzoli
Copy link
Collaborator

@sukidesuka I've created a pr #1256, can you out the fix ?

lburgazzoli added a commit to lburgazzoli/etcd-io-jetcd that referenced this issue Oct 18, 2023
lburgazzoli added a commit to lburgazzoli/etcd-io-jetcd that referenced this issue Oct 18, 2023
lburgazzoli added a commit that referenced this issue Oct 23, 2023
#1254

Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants