Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

election observe sometimes lose the first event #1308

Closed
tunefun opened this issue Jan 30, 2024 · 2 comments · Fixed by #1332
Closed

election observe sometimes lose the first event #1308

tunefun opened this issue Jan 30, 2024 · 2 comments · Fixed by #1332

Comments

@tunefun
Copy link
Contributor

tunefun commented Jan 30, 2024

          @lburgazzoli @giri-vsr hello, it seems that election observe have the same problem

stub.observe(request)
.handler(value -> listener.onNext(new LeaderResponse(value, namespace)))
.endHandler(ignored -> listener.onCompleted())
.exceptionHandler(error -> listener.onError(toEtcdException(error)));

and maybe we can also registers end handler before watch request?

Originally posted by @tunefun in #1261 (comment)

@lburgazzoli
Copy link
Collaborator

a pr and related integration test would be more than welcome

@tunefun
Copy link
Contributor Author

tunefun commented Jan 30, 2024

a pr and related integration test would be more than welcome

I think this issue same as origin issue, so I didn't describe too much. I will try to present a pr and integration test

tunefun added a commit to tunefun/jetcd that referenced this issue Mar 4, 2024
tunefun added a commit to tunefun/jetcd that referenced this issue Mar 5, 2024
tunefun added a commit to tunefun/jetcd that referenced this issue Mar 5, 2024
tunefun added a commit to tunefun/jetcd that referenced this issue Mar 5, 2024
lburgazzoli pushed a commit that referenced this issue Mar 9, 2024
Fixes #1308

Signed-off-by: tunefun <965728225@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants