Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions of lease keepAlive can be perceived #1322

Closed
tunefun opened this issue Feb 21, 2024 · 0 comments · Fixed by #1331
Closed

Exceptions of lease keepAlive can be perceived #1322

tunefun opened this issue Feb 21, 2024 · 0 comments · Fixed by #1331

Comments

@tunefun
Copy link
Contributor

tunefun commented Feb 21, 2024

Is your feature request related to a problem? Please describe.
Here is the keepAlive method: public synchronized CloseableClient keepAlive(long leaseId, StreamObserver<LeaseKeepAliveResponse> observer)

When some exceptions happened, such as connection failed, keekAlive will automatically restart, but there are no logs or callbacks, if deadline comes before fault recovery, onCompleted method of StreamObserver will be called, but we don't know what happened.

Describe the solution you'd like
I'd like onError method of StreamObserver should be called when some exceptions happened in lease keepAlive

tunefun pushed a commit to tunefun/jetcd that referenced this issue Mar 4, 2024
tunefun added a commit to tunefun/jetcd that referenced this issue Mar 4, 2024
Fixes etcd-io#1322

Signed-off-by: tunefun <965728225@qq.com>
tunefun added a commit to tunefun/jetcd that referenced this issue Mar 5, 2024
Fixes etcd-io#1322

Signed-off-by: tunefun <965728225@qq.com>
lburgazzoli pushed a commit that referenced this issue Mar 5, 2024
Fixes #1322

Signed-off-by: tunefun <965728225@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant