Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure any service threads are created as daemon threads. #1137

Closed
wants to merge 13 commits into from
Closed

Ensure any service threads are created as daemon threads. #1137

wants to merge 13 commits into from

Conversation

jcferretti
Copy link
Contributor

Fixes #1136

lburgazzoli
lburgazzoli reviewed May 27, 2023
View reviewed changes
jetcd-core/src/main/java/io/etcd/jetcd/impl/ClientConnectionManager.java Outdated
@@ -174,7 +175,7 @@ ManagedChannelBuilder<?> defaultChannelBuilder(String target) {
throw new IllegalArgumentException("At least one endpoint should be provided");
}
if (vertx == null) {
vertx = Vertx.vertx();
vertx = Vertx.vertx(new VertxOptions().setUseDaemonThread(builder.useDaemonThread()));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although I appreciate you took backward compatibility into account, given this is mainly used as a library, I wonder if this should be the default behavior and avoid adding yet another configuration option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, that simplifies matters a lot and certainly helps us fix our issue.

@lburgazzoli
Copy link
Collaborator

lburgazzoli commented May 28, 2023 •
edited
Loading

@jcferretti can you please rebase ? I think there were an issue with the ssl test preventing it to terminate

@jcferretti jcferretti changed the title Provide the means to configure any service threads created as daemon threads. Ensure any service threads are created as daemon threads. May 28, 2023
jcferretti and others added 13 commits May 29, 2023 12:28
@jcferretti
Provide the means to configure any service threads created as daemon …
406ba5b 
…threads.

Signed-off-by: Cristian Ferretti <cristianferretti@deephaven.io>
@jcferretti
Followup to review comment.
f0ee9b2 
Signed-off-by: Cristian Ferretti <cristianferretti@deephaven.io>
@jcferretti
Spotlessfy.
5191bc5 
Signed-off-by: Cristian Ferretti <cristianferretti@deephaven.io>
@lburgazzoli @jcferretti
chore(deps): update gradle
34358fc
@lburgazzoli @jcferretti
chore(deps): enable depndabot
cc2cd84
@lburgazzoli @jcferretti
chore(deps): configure dependabot to ignore protoc
d544186
@lburgazzoli @jcferretti
chore(test): re-generate ssl certs
0e2191c
@dependabot @jcferretti
build(deps): bump io.vertx:vertx-grpc from 4.4.0 to 4.4.2
d125782 
Bumps io.vertx:vertx-grpc from 4.4.0 to 4.4.2.

---
updated-dependencies:
- dependency-name: io.vertx:vertx-grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @jcferretti
build(deps): bump grpc from 1.53.0 to 1.55.1
d57fe29 
Bumps `grpc` from 1.53.0 to 1.55.1.

Updates `io.grpc:grpc-core` from 1.53.0 to 1.55.1
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.53.0...v1.55.1)

Updates `io.grpc:grpc-netty` from 1.53.0 to 1.55.1
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.53.0...v1.55.1)

Updates `io.grpc:grpc-protobuf` from 1.53.0 to 1.55.1
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.53.0...v1.55.1)

Updates `io.grpc:grpc-stub` from 1.53.0 to 1.55.1
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.53.0...v1.55.1)

Updates `io.grpc:grpc-grpclb` from 1.53.0 to 1.55.1
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.53.0...v1.55.1)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.grpc:grpc-netty
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.grpc:grpc-protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.grpc:grpc-stub
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.grpc:grpc-grpclb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @jcferretti
build(deps): bump org.slf4j:slf4j-api from 2.0.6 to 2.0.7
6b3a485 
Bumps [org.slf4j:slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.6 to 2.0.7.
- [Commits](qos-ch/slf4j@v_2.0.6...v_2.0.7)

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @jcferretti
build(deps): bump autoService from 1.0.1 to 1.1.0
549750e 
Bumps `autoService` from 1.0.1 to 1.1.0.

Updates `com.google.auto.service:auto-service-annotations` from 1.0.1 to 1.1.0
- [Release notes](https://github.com/google/auto/releases)
- [Commits](google/auto@auto-common-1.0.1...auto-value-1.1)

Updates `com.google.auto.service:auto-service` from 1.0.1 to 1.1.0
- [Release notes](https://github.com/google/auto/releases)
- [Commits](google/auto@auto-common-1.0.1...auto-value-1.1)

---
updated-dependencies:
- dependency-name: com.google.auto.service:auto-service-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.auto.service:auto-service
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@lburgazzoli @jcferretti
chore(deps): add dependency-review-action
d5fc0a2
@dependabot @jcferretti
build(deps): bump errorprone from 2.18.0 to 2.19.1
5f0978b 
Bumps `errorprone` from 2.18.0 to 2.19.1.

Updates `com.google.errorprone:error_prone_core` from 2.18.0 to 2.19.1
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.18.0...v2.19.1)

Updates `com.google.errorprone:error_prone_annotations` from 2.18.0 to 2.19.1
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.18.0...v2.19.1)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@jcferretti
Copy link
Contributor Author

I am redoing this PR from scratch; I merged instead of rebasing and that resulting in overall sadness.

@jcferretti jcferretti closed this May 29, 2023
@jcferretti
Copy link
Contributor Author

Redone here: #1146

@jcferretti jcferretti mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide the means in client builder to configure any service threads created as daemon threads
2 participants
@jcferretti @lburgazzoli