Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure any service threads are created as daemon threads (redo). #1146

Merged
merged 1 commit into from
May 30, 2023
Merged

Ensure any service threads are created as daemon threads (redo). #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion jetcd-core/src/main/java/io/etcd/jetcd/ClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
import com.google.common.collect.Streams;

/**
* ClientBuilder knows how to create an Client instance.
* ClientBuilder knows how to create a Client instance.
*/
public final class ClientBuilder implements Cloneable {

Expand Down
3 changes: 2 additions & 1 deletion jetcd-core/src/main/java/io/etcd/jetcd/impl/ClientConnectionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import io.grpc.stub.AbstractStub;
import io.netty.channel.ChannelOption;
import io.vertx.core.Vertx;
import io.vertx.core.VertxOptions;
import io.vertx.grpc.VertxChannelBuilder;

import com.google.common.util.concurrent.ListenableFuture;
Expand Down Expand Up @@ -174,7 +175,7 @@ ManagedChannelBuilder<?> defaultChannelBuilder(String target) {
throw new IllegalArgumentException("At least one endpoint should be provided");
}
if (vertx == null) {
vertx = Vertx.vertx();
vertx = Vertx.vertx(new VertxOptions().setUseDaemonThread(true));
}
final VertxChannelBuilder channelBuilder = VertxChannelBuilder.forTarget(vertx, target);

Expand Down