Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache and schedule for ghaction #1178

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Add cache and schedule for ghaction #1178

merged 1 commit into from
Jun 30, 2023

Conversation

liangyuanpeng
Copy link
Contributor

  • Add github gradle cache for CI
  • Add schedule to run ci every day

lburgazzoli
lburgazzoli reviewed Jun 25, 2023
View reviewed changes
.github/workflows/build-pr.yml Outdated
@@ -25,6 +25,8 @@ on:
branches:
- main
workflow_dispatch:
schedule:
- cron: "0 0 * * *"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose for that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run CI with schedule for discover flack tests early, does make sence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow only runs on PRs so I don't think it makes much sense

Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Jun 28, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved schedule to main workflow,and testing for run snapshot exclude schedule.

@liangyuanpeng
Copy link
Contributor Author

@lburgazzoli PTAL,Thanks.

@lburgazzoli
Copy link
Collaborator

@liangyuanpeng rebase required

@liangyuanpeng
Add cache and schedule for ghaction
c984485 
Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng
Copy link
Contributor Author

@lburgazzoli Done,Thanks.

@lburgazzoli lburgazzoli merged commit 5c150ac into etcd-io:main Jun 30, 2023
3 checks passed
@liangyuanpeng liangyuanpeng deleted the ghaction_cache branch July 18, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liangyuanpeng @lburgazzoli