[ghaction] martix CI for etcd version #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
requested changes
Jun 30, 2023
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
| import java.util.*; |
There was a problem hiding this comment.
please don't use star import
| @@ -89,6 +85,10 @@ public Builder withNetwork(Network network) { | |||
| } | |||
|
|
|||
| public EtcdCluster build() { | |||
| String imagePro = System.getenv("ETCD_IMAGE"); | |||
| if (!Strings.isNullOrEmpty(imagePro)) { | |||
| image = imagePro; | |||
There was a problem hiding this comment.
this should be done in the constructor, otherwise it would override any call to withImage
There was a problem hiding this comment.
@lburgazzoli PTAL,Thanks.
liangyuanpeng
force-pushed
the
matrix_etcd_ci
branch
2 times, most recently
from
a15ba44
to
e64b4db
Compare
lburgazzoli
reviewed
Jun 30, 2023
| public Builder(){ | ||
| String image = System.getenv("ETCD_IMAGE"); | ||
| if (!Strings.isNullOrEmpty(image)) { | ||
| withImage(image); |
There was a problem hiding this comment.
invoking a non final method from the constructor is usually a bad practice as could lead to unexpected results, better to set the instance variable directly.
As alternative you can create a static utility method that returns the container image, like:
private String image = Etcd.resolveContainerImage();
liangyuanpeng
force-pushed
the
matrix_etcd_ci
branch
from
e64b4db
to
7153cf1
Compare
lburgazzoli
approved these changes
Jun 30, 2023
Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
matrix_etcd_ci
branch
from
7153cf1
to
2614584
Compare
|
Thanks for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martix CI for etcd version,Improve client stability.
We can add CI for etcd 3.6.x after it's released.