Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove trailing spaces and add newlines for non-Java files #1217

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

johnshajiang
Copy link
Contributor

Spotless plugin just takes charge of Java files, and no tool concerns non-Java files. So, some of non-Java files have many trailing spaces and miss newlines.

Signed-off-by: John Jiang <john.sha.jiang@gmail.com>
@johnshajiang
Copy link
Contributor Author

@lburgazzoli
Thanks for approving this PR.
If no concern or problem, could you please merge this patch?

This commit changes dozens of files, then it possibly will conflict with future PRs.

@lburgazzoli lburgazzoli merged commit 471c569 into etcd-io:main Sep 6, 2023
4 checks passed
@johnshajiang johnshajiang deleted the fix-space-newline branch September 6, 2023 09:19
@liangyuanpeng
Copy link
Contributor

@johnshajiang

Just for confirm that this pr just working for once time , right?

It's not working if i create a new file and have not newlines.

@johnshajiang
Copy link
Contributor Author

@liangyuanpeng

Just for confirm that this pr just working for once time , right?
It's not working if i create a new file and have not newlines.

Yes.
The GitHub workflow should need one more check for this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants