build: test with OpenJDK 17 #1219
Conversation
Signed-off-by: John Jiang <john.sha.jiang@gmail.com>
|
I think we can waiting for java 21. |
| @@ -42,6 +42,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| java-version: [11, 17] | |||
There was a problem hiding this comment.
Also need to update https://github.com/etcd-io/jetcd/blob/main/.github/workflows/build-main.yml
There was a problem hiding this comment.
I did think about this point.
Frankly, I was not sure what are the purposes of build-main.yml and build-tag.yml.
So, I focus on PR only. And that is why the title is test with OpenJDK 17 on PR.
There was a problem hiding this comment.
build tag was an attempt to automate the release process but it is not yet working
There was a problem hiding this comment.
I just updated build-main.yml and added OpenJDK 17 for build job only.
Not sure when Gradle can support JDK 21. |
Signed-off-by: John Jiang <john.sha.jiang@gmail.com>
johnshajiang
force-pushed
the
test-on-jdk17
branch
from
224a595
to
e7a027a
Compare
johnshajiang
changed the title
|
@lburgazzoli Please feel free to give your suggestions or concerns. |
|
@lburgazzoli In addition, I just have a suggestion. |
|
@johnshajiang I usually do ask the author to squash the commits as the author knows better. In this case I could probably have done it but that leaves to me the role of deciding the commit message and the description which may lead to remove some useful context the author wanted to preserve. |
|
@lburgazzoli |
certainly, it was also very hard to get someone committed to do some good work so request to get reproducers, fix stuffs in PR and what not has always been a little bit not easy to achieve so as result I take the easy path and I fix things later on when I have time so any active contribution is more than welcome :) |
Now that jetcd should support OpenJDK 11+, it would be better to test not only OpenJDK 11, but OpenJDK 17 as well.
For example, the issue fixed by #1216 can only be reproduced with OpenJDK 13+.