-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check javadoc at PR CI #1246
check javadoc at PR CI #1246
Conversation
I'm not sure this is the real issue as gradle should mot require to have stuffs pushed to the local maven repo |
@lburgazzoli This is a problem of javadoc, and this PR try to find the problem of javadoc with publish to local maven. Does make sense? |
.github/workflows/build-pr.yml
Outdated
@@ -75,3 +75,6 @@ jobs: | |||
|
|||
./gradlew check -x test | |||
./gradlew test | |||
- name: Publish Snapshot to local maven | |||
run: | | |||
./gradlew publishToMavenLocal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this since is should not be required?
it should not be required to publish to local maven to validate javadoc, you can probably leverage the javadoc task for this purpose. also ideally sanity check should be performed before the build and test phase to avoid wasting compute resources and time |
3f5040b
to
ca48c35
Compare
ca48c35
to
f037f86
Compare
Check the error of javadoc:
|
Signed-off-by: Lan Liang <gcslyp@gmail.com>
f037f86
to
414c832
Compare
Since #1234 is merged, Publish Snapshot with main github acion is failed, this PR is work for block in advance
with publish to local maven at PR CI.https://github.com/etcd-io/jetcd/actions/runs/6483249273/job/17604772897
And fix CI.