Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check javadoc at PR CI #1246

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Oct 12, 2023

Since #1234 is merged, Publish Snapshot with main github acion is failed, this PR is work for block in advance with publish to local maven at PR CI.

https://github.com/etcd-io/jetcd/actions/runs/6483249273/job/17604772897

/home/runner/work/jetcd/jetcd/jetcd-core/src/main/java/io/etcd/jetcd/maintenance/DefragmentResponse.java:25: error: reference not found

 * DefragmentResponse returned by {@link Maintenance#defragmentMember(URI)} contains a header.
                                         ^
/home/runner/work/jetcd/jetcd/jetcd-core/src/main/java/io/etcd/jetcd/maintenance/StatusResponse.java:25: error: reference not found
 * StatusResponse returned by {@link Maintenance#statusMember(URI)} contains
> Task :jetcd-core:javadoc
                                     ^
/home/runner/work/jetcd/jetcd/jetcd-core/src/main/java/io/etcd/jetcd/maintenance/HashKVResponse.java:25: error: reference not found
 * HashKVResponse returned by {@link Maintenance#hashKV(URI, long)}.
                                     ^

And fix CI.

@lburgazzoli
Copy link
Collaborator

I'm not sure this is the real issue as gradle should mot require to have stuffs pushed to the local maven repo

@liangyuanpeng
Copy link
Contributor Author

@lburgazzoli This is a problem of javadoc, and this PR try to find the problem of javadoc with publish to local maven. Does make sense?

@@ -75,3 +75,6 @@ jobs:

./gradlew check -x test
./gradlew test
- name: Publish Snapshot to local maven
run: |
./gradlew publishToMavenLocal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this since is should not be required?

@lburgazzoli
Copy link
Collaborator

@lburgazzoli This is a problem of javadoc, and this PR try to find the problem of javadoc with publish to local maven. Does make sense?

it should not be required to publish to local maven to validate javadoc, you can probably leverage the javadoc task for this purpose.

also ideally sanity check should be performed before the build and test phase to avoid wasting compute resources and time

@liangyuanpeng liangyuanpeng changed the title publish to local maven for ci check javadoc at PR CI Oct 12, 2023
@liangyuanpeng
Copy link
Contributor Author

Check the error of javadoc:

...
> Task :jetcd-core:pmdMain
/home/runner/work/jetcd/jetcd/jetcd-core/src/main/java/io/etcd/jetcd/maintenance/DefragmentResponse.java:19:	UnnecessaryImport:	Unused import 'java.net.URI'

> Task :jetcd-core:pmdMain FAILED

> Task :jetcd-core:compileTestJava
FAILURE: Build failed with an exception.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@lburgazzoli lburgazzoli merged commit 485b67b into etcd-io:main Oct 12, 2023
7 checks passed
@liangyuanpeng liangyuanpeng deleted the ci_publishtolocal branch October 12, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants