watcher: Register Exception Handler before watch request #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giri Ramasamy <46867712+giri-vsr@users.noreply.github.com>
|
@lburgazzoli can you please check this? |
|
is there a chance to add a test case for this ? |
I couldn't replicate the issue with test containers.But the issue happens when we have this in k8s |
|
have you validated the change on k8s ? |
Haven't validated yet.Will validate and confirm.Is it possible to get a SNAPSHOT version for this PR? |
|
once the main build ends, a snapshot should be published to the snapshot repo |
|
@lburgazzoli I have tested with snapshot from main in k8s and It is working now. |
|
@lburgazzoli when can I expect next release? |
|
I can try to do a release today or beginning next week |
|
0.7.7 should be available to maven central soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers Exception handler before watch request so that if exception happens watch can resume.
Fixes #1261