Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fix of offline-search popup close button, w/o a docsy override #493

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Style fix of offline-search popup close button, w/o a docsy override #493

merged 1 commit into from
Sep 20, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 20, 2021 •
edited

@chalin chalin added cleanup/refactoring docsy Categorizes issue or PR as related to the docsy conversion project. design/style Front-end site design / styling labels Sep 20, 2021
@chalin chalin mentioned this pull request Sep 20, 2021
Merged
nate-double-u
nate-double-u approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, thanks @chalin

@nate-double-u nate-double-u merged commit cf71d1f into etcd-io:main Sep 20, 2021
@chalin chalin deleted the chalin-drop-offline-srch-override-2021-09-20 branch September 20, 2021 19:21
@chalin chalin mentioned this pull request Sep 20, 2021
Closed
3 tasks
chalin added a commit to chalin/etcd-io-website that referenced this pull request Sep 21, 2021
@chalin
Revert the CSS change of etcd-io#493
2128171
chalin added a commit that referenced this pull request Sep 21, 2021
@chalin
Docsy update 2021-09-21 (#496)
cb24711 
* Update docsy 2021-09-21
* Revert the CSS change of #493
@nate-double-u nate-double-u mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
cleanup/refactoring design/style Front-end site design / styling docsy Categorizes issue or PR as related to the docsy conversion project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chalin @nate-double-u