Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved sidebar indentation #497

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Improved sidebar indentation #497

merged 1 commit into from
Sep 21, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 21, 2021

  • Followup to Upgrade docsy #494
  • Removes sidebar indentation from version top-level pages, giving us more sidebar real estate for nested pages. (We don't lose anything w/o that level of indentation because one is never looking at the pages across two versions at the same time, and it is clear which version section we're in.)
  • Use the same sidebar indentation for desktop & mobile (as opposed to the default mobile all-flat sidebar)

Screenshots

Desktop

Before:

image

After:

image

Mobile

Before:

After:

@chalin chalin added the design/style Front-end site design / styling label Sep 21, 2021
@chalin chalin added the docsy Categorizes issue or PR as related to the docsy conversion project. label Sep 21, 2021
nate-double-u
nate-double-u approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tested on:

  • Firefox 92 on Ubuntu 20.04.1
  • Safari on iOS 14.8
  • Safari 14.1.2 on macOS 10.15.7

@nate-double-u nate-double-u merged commit f6422b7 into etcd-io:main Sep 21, 2021
@chalin chalin deleted the chalin-better-sidebar-styling-2021-09-21 branch September 21, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
design/style Front-end site design / styling docsy Categorizes issue or PR as related to the docsy conversion project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chalin @nate-double-u