Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the api guarantees based on Kubernetes-etcd implicit contract document #676

Merged
merged 1 commit into from
May 5, 2023

Conversation

serathius
Copy link
Member

@serathius serathius commented Apr 27, 2023

Document https://docs.google.com/document/d/1NUZDiJeiIH5vo_FMaTWf0JtrQKCx0kpEaIIuPoj9P6A/edit?usp=sharing

Some concepts don't match one to one K8s only requires a subset of things guaranteed by etcd.
For now updated only v3.6 section for clarity. Will send a followup for v3.5.

cc @ahrtr @ptabor @logicalhan @jpbetz @thockin @deads2k @wojtek-t

@serathius serathius force-pushed the api-contract branch 3 times, most recently from cbfb17d to 7bd099b Compare April 27, 2023 15:01
@serathius
Copy link
Member Author

ping @ahrtr @ptabor

@serathius
Copy link
Member Author

Part of etcd-io/etcd#15820

content/en/docs/v3.6/learning/api.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
content/en/docs/v3.6/learning/api_guarantees.md Outdated Show resolved Hide resolved
@serathius serathius force-pushed the api-contract branch 2 times, most recently from 1aa7dbd to 799924f Compare May 4, 2023 14:17
@serathius
Copy link
Member Author

Addressed all comments, PTAL @ahrtr @spzala @ptabor

@ahrtr
Copy link
Member

ahrtr commented May 5, 2023

Addressed all comments, PTAL @ahrtr @spzala @ptabor

https://github.com/etcd-io/website/pull/676/files#r1185642861 isn't resolved yet.

…document

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Co-authored-by: Benjamin Wang <wachao@vmware.com>
@serathius
Copy link
Member Author

Addressed all comments, PTAL @ahrtr @spzala @ptabor

https://github.com/etcd-io/website/pull/676/files#r1185642861 isn't resolved yet.

Ups, forgot to push.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @serathius

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @serathius

@spzala spzala merged commit f2a7f4f into etcd-io:main May 5, 2023
serathius added a commit to serathius/website-1 that referenced this pull request Mar 27, 2024
…d v3.4 release

Original PR etcd-io#676

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius added a commit to serathius/website-1 that referenced this pull request Mar 27, 2024
…d v3.4 release

Original PR etcd-io#676

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
ivanvc pushed a commit to ivanvc/etcd-website that referenced this pull request May 13, 2024
…d v3.4 release

Original PR etcd-io#676

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
wenjiaswe pushed a commit that referenced this pull request Jun 13, 2024
…d v3.4 release

Original PR #676

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants