-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux installation instructions #774
Add Linux installation instructions #774
Conversation
7803787
to
0622ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this proposal together @ivanvc, a few thoughts below.
641cedf
to
393d219
Compare
393d219
to
33d9e4e
Compare
@jmhbnz, please take another look at the updated text. Thanks. |
33d9e4e
to
5ae90f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ivanvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but two comments that we should address if you agree. Thanks @ivanvc
Signed-off-by: Ivan Valdes <ivan@vald.es>
5ae90f2
to
c0eca1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quickly addressing comments @ivanvc
I checked on pkgs.org, which distributions provide an etcd package. As @jmhbnz exposed on the biweekly triage meeting, most major distributions have outdated packages. So, I wrote the instructions for the distributions with an up-to-date version (and Homebrew).
Previews:
Fixes #767