-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc of listen-client-urls and listen-client-http-urls #866
Conversation
/cc @jmhbnz |
@Sadamingh: GitHub didn't allow me to request PR reviews from the following users: Thanks. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this @Sadamingh, looks good, just need to update the other docs versions mentioned below as well.
16448a4
to
427b1fd
Compare
Update: added --listen-client-http-urls flag directions to doc v3.4 and v3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sadamingh - One last issue to fix for default value then this will be good to merge.
427b1fd
to
2911f66
Compare
Thanks @jmhbnz , cleaned up default port for this flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @Sadamingh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Sadamingh. This looks great; I left two minor possible improvements.
Signed-off-by: Sadamingh <yxing11@usfca.edu>
2911f66
to
0d6e903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sadamingh lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Sadamingh
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz, Sadamingh, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR for issue: #777 to - doc on listen-client-http-urls for gRPC and HTTP seperation.
Original discussions: : etcd-io/etcd#15446