Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the file how-to-conduct-elections.md #867

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shubhdeep02
Copy link

@Shubhdeep02 Shubhdeep02 commented Jun 24, 2024

Explanation improvement....for the issue #787

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shubhdeep02 to pass DCO, the Signed-off-byline is not needed in the PR description but you need it in your commit message. Also, please add some details in the PR description about the changes or issue number if there is any issue this PR fixes. Thanks!

@Shubhdeep02
Copy link
Author

Thanks @spzala was just about to do..

@jmhbnz
Copy link
Member

jmhbnz commented Jun 24, 2024

Hey @Shubhdeep02 - Please rebase and squash commits, there should only be a single commit for this pull request, thanks.

@Shubhdeep02
Copy link
Author

Hey @jmhbnz i have rebased the commits please take a look into it.

@jmhbnz
Copy link
Member

jmhbnz commented Jun 25, 2024

Hey @jmhbnz i have rebased the commits please take a look into it.

Thanks - there are still three commits showing, please squash your commits.

@Shubhdeep02
Copy link
Author

@jmhbnz I guess they aren't part of the changed file but some self generated version update file. So should they be squashed?

Signed-off-by: Shubhdeep02 <shubhdeepsingh1502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants