-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of the file how-to-conduct-elections.md #867
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shubhdeep02 to pass DCO, the Signed-off-by
line is not needed in the PR description but you need it in your commit message. Also, please add some details in the PR description about the changes or issue number if there is any issue this PR fixes. Thanks!
Thanks @spzala was just about to do.. |
cec1b66
to
4eaae59
Compare
Hey @Shubhdeep02 - Please rebase and squash commits, there should only be a single commit for this pull request, thanks. |
Hey @jmhbnz i have rebased the commits please take a look into it. |
Thanks - there are still three commits showing, please squash your commits. |
@jmhbnz I guess they aren't part of the changed file but some self generated version update file. So should they be squashed? |
Signed-off-by: Shubhdeep02 <shubhdeepsingh1502@gmail.com>
Explanation improvement....for the issue #787