Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tonic to 0.11 #75

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Update tonic to 0.11 #75

merged 1 commit into from
Jun 1, 2024

Conversation

yotamofek
Copy link
Contributor

This raises the MSRV to 1.70, so probably warrants a minor release, though I don't think etcd-client actually specifies an MSRV.

@MichaelScofield
Copy link

@yotamofek @davidli2010 any updates?

@davidli2010
Copy link
Contributor

davidli2010 commented Apr 4, 2024

I'm waiting for hyperium/tonic#1670.

@tiagolobocastro
Copy link

I'm waiting for hyperium/tonic#1670.

That seems like a huge change in tonic...
Perhaps might be more conservative to update to 0.11 first, and then the big one later on?

@davidli2010
Copy link
Contributor

I'm waiting for hyperium/tonic#1670.

That seems like a huge change in tonic... Perhaps might be more conservative to update to 0.11 first, and then the big one later on?

Is tonic 0.11badly needed?

@tiagolobocastro
Copy link

Is tonic 0.11badly needed?

Not that badly needed for me tbh, just a would be good to have to keep same tonic version in my project.
Maybe @yotamofek has more needs?

@yotamofek
Copy link
Contributor Author

Is tonic 0.11badly needed?

Not that badly needed for me tbh, just a would be good to have to keep same tonic version in my project. Maybe @yotamofek has more needs?

Same here, just trying to minimize duplicated dependencies in my Cargo.lock. I think hyperium/tonic#1670 still has some time before it's merged, IMHO it would be nice to have an interim release of etcd-client in the meantime.

@davidli2010 davidli2010 merged commit 6eb53ab into etcdv3:master Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants