Fix memory leak in RefCounted, hashmap errors

etcimon · Dec 17, 2023 · 414a767 · 414a767
1 parent 9f02938
commit 414a767
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,6 @@
 .dub
 *.exe
 *.lib
-*.pdb
+*.pdb
+*.a
+*-unittest
diff --git a/source/memutils/debugger.d b/source/memutils/debugger.d
@@ -12,7 +12,7 @@ version(LogAllocations) static if (HasDebugAllocations) {
 
 	static __gshared FileLogger sharedLog;
 	static this() {
-		sharedLog = new FileLogger("allocations.log", LogLevel.trace);
+		sharedLog = new FileLogger("../allocations.log", LogLevel.trace);
 	}
 }
 

diff --git a/source/memutils/hashmap.d b/source/memutils/hashmap.d
@@ -76,7 +76,7 @@ struct HashMap(Key, Value, ALLOC = ThreadMem)
 		auto idx = this.findIndex(key);
 		if (idx == size_t.max) return default_value;
 		const Value ret = m_table[idx].value;
-		return cast()ret;
+		return cast(Value)ret;
 	}
 	/*	
 	static if (!is(typeof({ Value v; const(Value) vc; v = vc; }))) {

diff --git a/source/memutils/refcounted.d b/source/memutils/refcounted.d
@@ -66,9 +66,7 @@ struct RefCounted(T, ALLOC = ThreadMem)
 		if (!m_object) {
 			defaultInit(); 
 			checkInvariants();
-		}
-
-		if (m_object) (*m_refCount)++;		
+		} else (*m_refCount)++;		
 	}
 
 	void opAssign(U : RefCounted)(in U other) const nothrow